Where Is The Best Place To Train For The Elite Four (leaf Green)?

Use the VS Seeker on the people outside the Ember Spa. GOod because you can heal in the spa after battles, all the while recharging the VS seeker.

I too am struggling with training for the elite four and I need a level 55 team to beat them. Use every method that you get suggested and here are mine. Victory Road is good for water pokemon. When you try to get to Moltress on Leafgreen there is a bunch of Machokes level 40 in there and you could get Flying pokemon and lots of pokemon leveled up there. Outside Ember Spa is 2 karate masters and a double battle. Two pokemon that have two attacking moves like surf that attacks both enemies. Use that with like a dragonair with twister. Twister kind sucks but it helps Blastoise on your side with surf. Find a strong trainer that you struggled with outside not inside a building. Use the VS. Seeker and get lots of exp. Never equip the exp share to pokemon it slows down the process for the attacking for. Exp share does not double exp in battle for the pokemon equipped with it, but it does give them like an extra 100 exp but nothing special. I hope I helped then just sayin ember spa,victory road,and thats it.

In cycling road ember spa the dojo the gyms an the victory
road

Depends on which EVs if you want attack EVs then with the trainers outside ember spa